Haque Farazul - Pet Park Assignment #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum animalType {None, Fish, Cat, Dog, Rabbit, Parrot} |
There was a problem hiding this comment.
Recommended to have enum names start with capital letters
| gender _gender; | ||
| uint age; | ||
| address memberAddress; |
There was a problem hiding this comment.
Storage is costly in solidity. You don't need to store this address since you are already have the address as key in members mapping
| } | ||
|
|
||
| function animalCounts(animalType _animalType) public view returns (uint) { |
There was a problem hiding this comment.
Since solidity public mappings are automatically exposed as functions, you can just make animalCounts as a public mapping
|
|
||
| function add (animalType _animalType, uint _count) public{ | ||
| require (owner == msg.sender, "Not an owner"); |
There was a problem hiding this comment.
Better to use a modifier here for checking owner as it provides better code readability
|
|
||
|
|
||
| function borrow (uint _age, gender _gender, animalType _animalType) public{ |
There was a problem hiding this comment.
This can be marked external since it is not being called anywhere internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.